This repository was archived by the owner on May 11, 2026. It is now read-only.
fix: restrict delete-proposal alias to Starknet authors#636
Merged
Conversation
Deletion is destructive; gate delete-proposal via alias behind a Starknet author check (matching the pre-refactor behavior). EVM aliases can still vote/propose/update/flag but cannot delete. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
@copilot Add these tests:
|
Agent-Logs-Url: https://github.com/snapshot-labs/snapshot-sequencer/sessions/7ad88c56-9721-44a8-90b9-c8adf0c094a3 Co-authored-by: ChaituVR <15967809+ChaituVR@users.noreply.github.com>
Contributor
Added both cases in cb14db7 — |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete-proposalfromTYPES_EXECUTABLE_BY_ALIAS.TYPES_EXECUTABLE_BY_STARKNET_ALIAS = ['delete-proposal']list and reintroduceisStarknetAddress.Follows up on #634, which inadvertently promoted
delete-proposalto EVM aliases when collapsing the type buckets. Deletion is destructive and irrecoverable, so the pre-refactor Starknet-only behavior is the safer default until alias-typed signers (user vs. agent, per snapshot-labs/workflow#793) land.Test plan
yarn lintdelete-proposalfrom an EVM alias rejects withalias not allowed for the type: delete-proposal.yarn test(CI)delete-proposalfor an EVM author → rejected.delete-proposalfor a Starknet author with a valid alias row → accepted.vote/proposal/update-proposal/flag-proposal→ still accepted (regression).🤖 Generated with Claude Code