This repository was archived by the owner on May 11, 2026. It is now read-only.
chore+fix: add Arbitrum onchain space to Tally statement importer#637
Merged
Conversation
Adds the Arbitrum Core Governor SX space to the Tally MAPPING so that delegate statements imported from Tally are stored against the onchain space and surfaced in the SX UI. Also fixes a crash when Tally returns a delegate with no statement (null instead of an empty object).
ChaituVR
changed the title
bonustrack
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/snapshot-labs/workflow/issues/804
What
Two small changes to the Tally statement importer:
Add Arbitrum onchain space to the MAPPING — the importer previously only knew about the legacy offchain Snapshot space (
s:arbitrumfoundation.eth). This adds the Arbitrum Core Governor SX space (arb1:0x789fC99093B09aD01C34DC7251D0C89ce743e5a4) so that Tally delegate statements get stored with the correctnetworkandspacevalues that the SX UI queries.Fix crash when Tally returns
nullfor a delegate's statement — Tally's API sometimes returnsstatement: nullinstead ofstatement: { statement: "" }for delegates who haven't written a statement. The previous code assumed the object was always present and crashed withCannot read properties of null. Changed to optional chaining (?.) so those delegates are safely skipped.How to run
Test plan
network='arb1',space='0x789…',source='tally'statement: nullare skipped without crashing(network, space)and works for onchain spaces🤖 Generated with Claude Code