This repository was archived by the owner on Aug 22, 2025. It is now read-only.
ci: run lint workflow on pull request#1744
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates CI workflows to include lint on pull requests, cleans up build job naming, and reformats a multiline constructor call for readability.
- Expand the lint workflow trigger to run on pull requests
- Rename the build job and adjust its step to remove lint
- Reformat
Multicallerinstantiation in the DeFi voting strategy to multiline
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/strategies/defi-app-voting/index.ts | Reformatted Multicaller instantiation to a multiline object for clarity |
| .github/workflows/lint.yml | Added pull_request to the on trigger for linting |
| .github/workflows/build.yml | Renamed build_lint job to build and updated step name |
wa0x6e
enabled auto-merge (squash)
June 8, 2025 15:33
Contributor
Author
|
This seems to be stuck for ever, since this workflow has been renamed |
ChaituVR
disabled auto-merge
June 8, 2025 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lintworkflow on pull request