This repository was archived by the owner on Aug 22, 2025. It is now read-only.
[delegated-ape] new delegated ape strategy#1746
Merged
Merged
Conversation
ChaituVR
commented
Jun 10, 2025
ChaituVR
commented
Jun 10, 2025
| 'function getEthBalance(address account) public view returns (uint256 balance)' | ||
| ]; | ||
|
|
||
| const CONTRACT_ADDRESS = '0xdd6b74123b2ab93ad701320d3f8d1b92b4fa5202'; |
Member
Author
There was a problem hiding this comment.
@bonustrack, do you think this should be hardcoded like this or passed in as parameters?
ChaituVR
marked this pull request as ready for review
June 10, 2025 06:20
Member
|
Delegation contract and ID should be a part of the params |
bonustrack
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/snapshot-labs/workflow/issues/572