fix(ci): update expired sepolia ENS fixture in lookupDomains test#482
Merged
Conversation
The sepolia lookup test asserted `testchaitu.eth`, a wrapped ENS name on sepolia that expired on 2026-07-01 (expiryDate 1782909240). lookupDomains filters out expired domains, so the name is correctly dropped and CI has failed on master since expiry. Switch the assertion to `chaitu.eth`, which the same account owns with an expiry in 2038, keeping the sepolia routing check intact without the time-brittle fixture. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
CI
Testhas been failing onmaster(and on the.gwei#480 + dependabot pushes). The single failing test islookupDomains › should return an array of addresses on sepolia:Root cause
testchaitu.ethis a wrapped ENS name on sepolia owned by the test account. Querying the live sepolia ENS subgraph shows itsexpiryDateis1782909240= 2026-07-01 12:34 UTC.lookupDomainsfilters out expired domains, so as of 2026-07-01 the name is correctly dropped and the hard-coded assertion breaks. This is a time-brittle fixture, unrelated to the .gwei PR or the snapshot.js dependency bump.Fix
Assert
chaitu.ethinstead. The same account owns it withexpiryDate2156590116(2038-05-04), so the sepolia-routing check stays intact without depending on a testnet name that lapses.Verification
testchaitu.ethexpired 2026-07-01,chaitu.ethvalid to 2038.jest test/integration/lookupDomains.test.ts -t sepoliapasses 3/3 runs with the fix.eslintclean on the touched file.(Other local suite failures — shibarium/unstoppable — are environment-only: they need the
D3_API_KEY*/UNSTOPPABLE_DOMAINS_API_KEYsecrets that CI provides; they pass in CI.)🤖 Generated with Claude Code