feat: filter out disabled offchain strategies #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR introduces a filter to hide offchain strategies that have been disabled, addressing the issue outlined in snapshot-labs/workflow#227.
- Added an optional "disabled" property to the StrategyTemplate type in types.ts.
- Updated the strategy filtering logic in Modal/Strategies.vue to exclude strategies marked as disabled.
Reviewed Changes
| File | Description |
|---|---|
| apps/ui/src/networks/types.ts | Added a new optional "disabled" flag for strategies. |
| apps/ui/src/components/Modal/Strategies.vue | Updated filtering logic to exclude disabled strategies. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
wa0x6e
force-pushed
the
fix-filter-out-disabled-strategies
branch
from
789cd15 to
efc08a1
Compare
wa0x6e
force-pushed
the
fix-filter-out-disabled-strategies
branch
from
efc08a1 to
c59d5cb
Compare
|
DO NOT MERGE UNTIL RELEASE DAY |
ChaituVR
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Toward https://github.com/snapshot-labs/workflow/issues/227
This PR will hide disabled offchain strategies
How to test