Skip to content

fix: hide irrelevant connectors from login modal #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Apr 4, 2025

Summary

Closes: #1295

This PR will hide the starknet login option for whitelabe offchain and onchain evm spaces.

How to test

  1. Run VITE_WHITE_LABEL_MAPPING='127.0.0.1;sn:0x07c251045154318a2376a3bb65be47d3c90df1740d8e35c9b9d943aa3f240e50' yarn dev then visit http://127.0.0.1:8080/#/
  2. All the connector should be present in the login modal
  3. Visit http://localhost:8080/#
  4. All the connectors should be present in the login modal
  5. Run VITE_WHITE_LABEL_MAPPING='127.0.0.1;base:0x8cF43759f3d4E72cB72cED6bd69cCe43d4428264' yarn dev then visit http://127.0.0.1:8080/#/
  6. Starknet connector should be missing from the login modal
  7. Run VITE_WHITE_LABEL_MAPPING='127.0.0.1;s:ens.eth' yarn dev then visit http://127.0.0.1:8080/#/
  8. Starknet connector should be missing from the login modal

@wa0x6e wa0x6e requested a review from Copilot April 4, 2025 21:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

apps/ui/src/components/Modal/Account.vue:40

  • [nitpick] Consider renaming 'supportedConnectorType' to 'supportedConnectors' to clearly indicate that the variable holds multiple connector options.
const supportedConnectorType = computed(() => {

apps/ui/src/components/Modal/Account.vue:41

  • [nitpick] Consider adding braces around the 'if' statement block for improved clarity and maintainability.
if (
    !whiteLabelSpace.value ||
    starknetNetworks.includes(whiteLabelSpace.value.network)
  )

@wa0x6e wa0x6e requested a review from bonustrack April 4, 2025 21:13
@wa0x6e wa0x6e marked this pull request as ready for review April 4, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ux: on whitelabel, only show evm connector for evm and offchain spaces
1 participant