Skip to content

fix: adapt scrollbar color to theme #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Apr 7, 2025

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/534

This issue will customize the scrollbar color to the light/dark/whitelabel theme

How to test

  1. Run VITE_WHITE_LABEL_MAPPING='127.0.0.1;s:test.wa0x6e.eth' yarn dev
  2. Visit http://127.0.0.1:8080/#/
  3. The scrollbar color should match the theme
  4. Visit localhost
  5. The scrollbar color for the light and dark theme should match

@wa0x6e wa0x6e requested review from bonustrack and Copilot April 7, 2025 21:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/ui/src/style.scss: Language not supported

@bonustrack
Copy link
Member

This is changing the default style of the scrollbar, can you make it so it stay the same color than currently? On light theme scrollbar bg should be white.

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Apr 8, 2025

Updated to be closer to default one.

Still can not match one to one, because we use existing variables. Another option would be to enable those custom colors only on whitelabel, but would require more code

Screenshot 2025-04-09 at 02 03 43
Screenshot 2025-04-09 at 02 03 31
Screenshot 2025-04-09 at 02 03 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants