Security: Sensitive credentials accepted via GET query parameters#1062
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
The API requires and consumes secrets like `access_token`, `refresh_token`, `app_password`, and OAuth token pairs from query parameters on a GET endpoint. Query strings are commonly logged by reverse proxies, browsers, analytics, and server logs, which can leak credentials and enable account takeover if logs are exposed. Affected files: api.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Owner
|
Hey, thanks for the contribution! This doesn't really help though. It just breaks existing functionality without providing an alternative. Also, based on https://github.com/tuanaiseo?tab=overview&from=2026-04-01&to=2026-04-02 , it looks like this is semi or fully automated. You should disclose that in these PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The API requires and consumes secrets like
access_token,refresh_token,app_password, and OAuth token pairs from query parameters on a GET endpoint. Query strings are commonly logged by reverse proxies, browsers, analytics, and server logs, which can leak credentials and enable account takeover if logs are exposed.Severity:
highFile:
api.pySolution
Move all secrets to
Authorizationheaders or POST body parameters, reject credential-bearing query params, and redact sensitive values in logs/metrics. Consider rotating any tokens that may already have been exposed via URLs.Changes
api.py(modified)Testing