Skip to content

Conversation

@jorainer
Copy link
Collaborator

- Change the column names of the `data.frame` returned by `chromatogram()` to
  `"rtime"` and `"intensity"` (issue #304).
@jorainer jorainer requested review from lgatto and sneumann January 29, 2025 10:48
@jorainer
Copy link
Collaborator Author

Added a quick additional change - chromatograms() was (silently) changing the result object type: is a single chromatogram was requested it returned a data.frame, if no chromatogram was specified, or multiple were requested it returned a list of data.frame. This causes some issues and additional checks in the Chromatograms package. I added now a new parameter drop = TRUE to the chromatograms() function that can be set to drop = FALSE so that always a list is returned (even for a single data.frame).

@jorainer jorainer closed this by deleting the head repository Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants