stale decetion uses retry_interval when needed#1496
Closed
inqrphl wants to merge 5 commits intosni:masterfrom
Closed
stale decetion uses retry_interval when needed#1496inqrphl wants to merge 5 commits intosni:masterfrom
inqrphl wants to merge 5 commits intosni:masterfrom
Conversation
revise the stale detection warning, - now is visible even if there arent any dependencies. - displays the last checked time - displays additional hints about core and gearman
inqrphl
commented
Apr 20, 2026
| else{ | ||
| $next_planned_check = $last_check + $retry_interval; | ||
| } | ||
| my $second_next_planned_check = 0; |
Contributor
Author
There was a problem hiding this comment.
basically did the same logic as next_planned_check, since we cannot be sure about which interval it used on the next step.
whether the next_planned_check made the state OK, not-OK , increased the current_attempt is unknown, since thruk did not hear about it.
sni
reviewed
Apr 22, 2026
| $next_planned_check = $last_check + $check_interval; | ||
| } | ||
| elsif ($state != 0 && $current_attempt != $max_check_attempts) { | ||
| $next_planned_check = $last_check + $check_interval; |
Owner
There was a problem hiding this comment.
shouldn't this be the retry_interval here?
Contributor
Author
There was a problem hiding this comment.
Yeah actually, I confused the logic.
sni
reviewed
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revise the stale detection warning,