Various Red v.s. Blue Alliance Cleanups and Fixes#87
Merged
martincarapia merged 1 commit intosnidercs:mainfrom Mar 6, 2025
Merged
Various Red v.s. Blue Alliance Cleanups and Fixes#87martincarapia merged 1 commit intosnidercs:mainfrom
martincarapia merged 1 commit intosnidercs:mainfrom
Conversation
* py: re-bind controller every time to update alliance * py: really lazy load controller bindings. * py: telemetry registration happens outside of button bindings * py: reset heading automatically every time teleop is init'd * py: fixup code style.
Contributor
Author
|
Hey @martincarapia by all means review my work in detail just as I would yours. 👍 |
| self._joystick = commands2.button.CommandXboxController (0) | ||
|
|
||
| # Cache the multiplier | ||
| self._driveMultiplier = -1.0 if self.isRedAlliance() else 1.0 |
Contributor
Author
There was a problem hiding this comment.
Thanks. It saves us a few function calls in the real-time thread. 👍
martincarapia
approved these changes
Mar 6, 2025
Member
martincarapia
left a comment
martincarapia
left a comment
There was a problem hiding this comment.
I like it, looks super good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84