Conversation
…ng connections succesfully
…osts Beefed up error contexts Docs
|
nice, definitely like the move into Run() of the blocking operation, makes sense. |
|
@hcliff I added that because I had issues with the signal handling code cleaning up after itself. Unfortunately when I wrote that existing code it was very had to get "right" (despite you saying you have issues with it). But if its really broken then the e2e tests fail which is what I am seeing on my branch now. I will try to give it a look this week. Thanks for giving this a shot. This main binary is a mess and really needs some loving. Hopefully this will be a good start. |
|
It's definitely tricky haha, after using my PR version locally for a couple of weeks I've found there's still a case where if the user kills dredd rapidly after starting a process is left running. (Pretty sure it's during that 100ms wait for the cmd to start running if you're digging into it). |
|
@hcliff yea I know 🙈 . Cool thanks for the tip. |
No description provided.