Skip to content

SCAN instead of KEYS and sanitization for encoding #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SCAN instead of KEYS and sanitization for encoding #54

wants to merge 1 commit into from

Conversation

Bobochka
Copy link

  1. Replace KEYS with SCAN in batches of 1K for full DB audit
  2. Fixes key invalid encoding issue

@Bobochka Bobochka force-pushed the scan_and_invalid_encoding branch from d8404d3 to e0b6529 Compare April 20, 2017 07:16
@Bobochka Bobochka force-pushed the scan_and_invalid_encoding branch from e0b6529 to c745e5b Compare April 21, 2017 16:02
ShonM
ShonM reviewed Mar 1, 2018
View reviewed changes
redis-audit.rb
rescue Redis::CommandError
$stderr.puts "Skipping key #{key}"
rescue Redis::CommandError => e
$stderr.puts "Skipping key #{key} (#{e.message})"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ShonM ShonM ShonM left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bobochka @ShonM