Skip to content

WIP: Multiple idps#201

Draft
peterfarrell wants to merge 3 commits into
snok:mainfrom
atdsaa:multiple_idps
Draft

WIP: Multiple idps#201
peterfarrell wants to merge 3 commits into
snok:mainfrom
atdsaa:multiple_idps

Conversation

@peterfarrell

Copy link
Copy Markdown
Contributor

WIP for #117

@codecov

codecov Bot commented Nov 19, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.1%. Comparing base (e9808eb) to head (c45c685).
⚠️ Report is 147 commits behind head on main.

Files with missing lines Patch % Lines
django_auth_adfs/config.py 79.5% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #201     +/-   ##
=======================================
+ Coverage   85.9%   86.1%   +0.2%     
=======================================
  Files         11      11             
  Lines        497     505      +8     
=======================================
+ Hits         427     435      +8     
  Misses        70      70             
Files with missing lines Coverage Δ
django_auth_adfs/config.py 87.8% <79.5%> (+0.4%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sondrelg

Copy link
Copy Markdown
Member

Hi @peterfarrell. What's the status for this PR? 🙂

@peterfarrell

Copy link
Copy Markdown
Contributor Author

@sondrelg Still a WIP and blocked by: jpadilla/pyjwt#433

@JonasKs

JonasKs commented Jan 3, 2022

Copy link
Copy Markdown
Member

Did you see my comment in #117 @peterfarrell ?

@peterfarrell

Copy link
Copy Markdown
Contributor Author

@JonasKs Yes, I did. I don't have the bandwidth to retro-fit anything more than a static list of issuers right now. I'm not familiar with Python-Jose. Does it have the same API as pyJWT?

@JonasKs

JonasKs commented Jan 4, 2022

Copy link
Copy Markdown
Member

Pretty much, yeah. It is a cleaner implementation, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants