Adjust logger levels to use info for side-effects#293
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=====================================
Coverage 86.1% 86.1%
=====================================
Files 11 11
Lines 556 556
=====================================
Hits 479 479
Misses 77 77
🚀 New features to boost your workflow:
|
|
Hi, and thank you 😊 I think the only reason I didn't want to do this in the past was because of the potential dashboards and warnings people may have set up. I don't really know if it makes sense to keep the potential of a broken dashboard in favor of fixing these to be more sensible - especially with Sentry being way more implemented than it was back when I created this. I approve. What do you think @sondrelg ? EDIT: oh, I thought you had lowered them from error to info. I'm more in favor of making them all info-statements than making more error-logs. It generates so much Sentry noise. |
|
At least for my usage, it would be nice to only log errors when something needs to be explicitly handled by a user. All our projects are set up to propagate error logs to Sentry, so that defines that for us, sort of 🤷 Maybe using |
|
I agree. I'm for info+warning and remove all error logs basically. |
|
What was your rationale here @stephane? |
No description provided.