Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master verification #1021

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Draft

master verification #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eedae8
test
sfc-gh-pmotacki Mar 4, 2025
6f2f610
log for system tests
sfc-gh-pmotacki Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/connection/statement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ function createContextPreExec(
statementContext.cwd = statementOptions.cwd;
}

// if the describeOnly flag is specified, add it to the statement context
// if the describeOnly flag is specified, add it to the statement context test
if (Util.exists(statementOptions.describeOnly)) {
statementContext.describeOnly = statementOptions.describeOnly;
}
Expand Down
3 changes: 3 additions & 0 deletions system_test/testSystemGetObjects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@
{
sqlText: sql,
complete: function (err, statement) {
console.log(`######### errr ${JSON.stringify(err)}`);

Check failure on line 413 in system_test/testSystemGetObjects.js

View workflow job for this annotation

GitHub Actions / Run lint 

Unexpected console statement
assert.ok(!err);
queryId = statement.getQueryId();
callback();
Expand All @@ -422,12 +423,14 @@
const columnName = 'map';
const sqlText = util.format('%s as "%s";',
buildSqlSystem$GetObjects(queryId), columnName);
console.log(`######### sql ${sqlText}`);

Check failure on line 426 in system_test/testSystemGetObjects.js

View workflow job for this annotation

GitHub Actions / Run lint 

Unexpected console statement
connSnowflake.execute(
{
sqlText: sqlText,
complete: function (err, statement, rows) {
assert.ok(!err);
assert.ok(rows && (rows.length === 1));
console.log(`######### rows ${JSON.stringify(rows)}`);

Check failure on line 433 in system_test/testSystemGetObjects.js

View workflow job for this annotation

GitHub Actions / Run lint 

Unexpected console statement
assert.deepStrictEqual(JSON.parse(rows[0][columnName]), output);
callback();
}
Expand Down
Loading