Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 1825478 pat support #1022

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Snow 1825478 pat support #1022

wants to merge 9 commits into from

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner March 5, 2025 13:04
@sfc-gh-pmotacki sfc-gh-pmotacki changed the base branch from master to SNOW-1883649-wiremock March 5, 2025 13:06
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1825478-PAT-support branch from 4c44ce4 to 56aa1c1 Compare March 5, 2025 13:39
@sfc-gh-pmotacki sfc-gh-pmotacki changed the base branch from SNOW-1883649-wiremock to master March 5, 2025 14:20
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1825478-PAT-support branch from 4e749e7 to 8a48b1c Compare March 6, 2025 08:31
sfc-gh-astachowski
sfc-gh-astachowski approved these changes Mar 7, 2025
View reviewed changes
lib/util.js
@@ -765,6 +766,18 @@ exports.isWindows = function () {
return os.platform() === 'win32';
};


exports.getFreePort = async function () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should go in testUtil.js instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I will try to move it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pmotacki @sfc-gh-astachowski