Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1763673 Python 3.13 support #2105

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Nov 13, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
    Fixes SNOW-1763673

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    These new versions usually need no code-changes. They should just work on new Python versions. I also took this opportunity to update pre-commit hooks and fix all files.

  4. (Optional) PR for stored-proc connector:

@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 13, 2024
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-1763673/python3.13-support branch from 8dfbfe4 to eb881d7 Compare November 13, 2024 04:24
@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 13, 2024
@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 13, 2024
@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 13, 2024
@sfc-gh-mkeller sfc-gh-mkeller added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Nov 13, 2024
@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Nov 13, 2024
@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 14, 2024
@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 14, 2024
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-1763673/python3.13-support branch from 45c5025 to d4d028e Compare November 14, 2024 00:47
@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 14, 2024
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-1763673/python3.13-support branch from d4d028e to a57dc10 Compare November 14, 2024 22:52
@snowflakedb snowflakedb deleted a comment from gitguardian bot Nov 14, 2024
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-1763673/python3.13-support branch from a57dc10 to fe10e5a Compare November 14, 2024 23:10
Copy link

gitguardian bot commented Nov 14, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-1763673/python3.13-support branch 5 times, most recently from 195cdde to 3832ff1 Compare November 18, 2024 21:27
@sfc-gh-mkeller sfc-gh-mkeller linked an issue Jan 23, 2025 that may be closed by this pull request
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-1763673 Python3.13 support SNOW-1763673 Python 3.13 support Jan 27, 2025
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-1763673/python3.13-support branch 3 times, most recently from 9f17fc8 to f7ef6ad Compare January 29, 2025 17:54
Copy link
Collaborator

@sfc-gh-mmishchenko sfc-gh-mmishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance we could leave nanoarrow part untouched?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1763673: Publish Python 3.13 wheels
4 participants