NO-SNOW: Revert one change that updates public API for internal use case #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-dwang
approved these changes
Jan 12, 2024
Collaborator
sfc-gh-dwang
left a comment
sfc-gh-dwang
left a comment
There was a problem hiding this comment.
LGTM, I can create a new PR after POC if necessary
We're hitting test failures during snapshot release and the reason is because there's no profile.json file, this PR adds a test mode in SnowflakeStreamingIngestClientFactory so that we can continue use dummyHost name for unit testing. 2024-01-09 23:17:26 testClientFactorySuccess(net.snowflake.ingest.streaming.internal.SnowflakeStreamingIngestClientTest) Time elapsed: 180.565 sec <<< ERROR! 2024-01-09 23:17:26 net.snowflake.ingest.utils.SFException: Unable to connect to streaming ingest internal stage. 2024-01-09 23:17:26 at net.snowflake.ingest.streaming.internal.SnowflakeStreamingIngestClientTest.testClientFactorySuccess(SnowflakeStreamingIngestClientTest.java:266) 2024-01-09 23:17:26 Caused by: net.snowflake.client.jdbc.internal.apache.http.conn.ConnectTimeoutException: Connect to snowflake.qa1.int.snowflakecomputing.com:443 [snowflake.qa1.int.snowflakecomputing.com/10.180.20.15, snowflake.qa1.int.snowflakecomputing.com/10.180.20.17, snowflake.qa1.int.snowflakecomputing.com/10.180.20.16] failed: connect timed out 2024-01-09 23:17:26 at net.snowflake.ingest.streaming.internal.SnowflakeStreamingIngestClientTest.testClientFactorySuccess(SnowflakeStreamingIngestClientTest.java:266) 2024-01-09 23:17:26 Caused by: java.net.SocketTimeoutException: connect timed out 2024-01-09 23:17:26 at net.snowflake.ingest.streaming.internal.SnowflakeStreamingIngestClientTest.testClientFactorySuccess(SnowflakeStreamingIngestClientTest.java:266) 2024-01-09 23:17:26 2024-01-09 23:17:26 testConstructorParameters(net.snowflake.ingest.streaming.internal.SnowflakeStreamingIngestClientTest) Time elapsed: 180.392 sec <<< ERROR!
sfc-gh-xhuang
approved these changes
Jan 16, 2024
Contributor
sfc-gh-xhuang
left a comment
sfc-gh-xhuang
left a comment
There was a problem hiding this comment.
thanks, best to remove before next sdk release
sfc-gh-japatel
approved these changes
Jan 17, 2024
Collaborator
sfc-gh-japatel
left a comment
sfc-gh-japatel
left a comment
There was a problem hiding this comment.
lgtm!
Please have a meaning description in the title PR to not have to open commits from change logs.
Thanks
sfc-gh-tzhang
changed the title
airlock-confluentinc bot
pushed a commit
to confluentinc/snowflake-ingest-java
that referenced
this pull request
Jun 20, 2025
…ase (snowflakedb#662) Revert 2b702db This change updates the public API for an internal special use case only which is not ideal, looks like we keep updating public APIs in snowflakedb#661 as well. Given that we're still in a POC phase, I suggest we do everything in another branch instead, hence removing this from the next public release and could discuss what's the best way to support this internal use case once the POC is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert 2b702db
This change updates the public API for an internal special use case only which is not ideal, looks like we keep updating public APIs in #661 as well. Given that we're still in a POC phase, I suggest we do everything in another branch instead, hence removing this from the next public release and could discuss what's the best way to support this internal use case once the POC is done.