Skip to content

SNOW-1545799-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD#1904

Closed
sfc-gh-ext-simba-jf wants to merge 16 commits intomasterfrom
SNOW-1313625-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD
Closed

SNOW-1545799-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD#1904
sfc-gh-ext-simba-jf wants to merge 16 commits intomasterfrom
SNOW-1313625-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD

Conversation

@sfc-gh-ext-simba-jf
Copy link
Copy Markdown
Collaborator

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf commented Sep 26, 2024

Overview

SNOW-1545799

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf changed the title Adding test for timestamp exceeding binding threshold SNOW-1313625-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD Nov 15, 2024
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-1313625-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD SNOW-1545799-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD Dec 19, 2024
@gitguardian
Copy link
Copy Markdown

gitguardian bot commented May 7, 2025

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
16606334 Triggered Generic High Entropy Secret 6377182 src/test/resources/wiremock/mappings/wif/azure/invalid_issuer_flow.json View secret
16606335 Triggered Generic High Entropy Secret 6377182 src/test/resources/wiremock/mappings/wif/azure/successful_flow_azure_functions_no_client_id.json View secret
16606336 Triggered Generic High Entropy Secret 6377182 src/test/resources/wiremock/mappings/wif/azure/missing_sub_claim.json View secret
16606337 Triggered Generic High Entropy Secret 6377182 src/test/resources/wiremock/mappings/wif/azure/missing_issuer_claim.json View secret
🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown
Contributor

sfc-gh-snowflakedb-snyk-sa commented May 7, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf marked this pull request as ready for review May 16, 2025 17:25
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner May 16, 2025 17:25
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf force-pushed the SNOW-1313625-Verify-value-bindings-exceeding-CLIENT_STAGE_ARRAY_BINDING_THRESHOLD branch from f8feda0 to 1f85efe Compare May 28, 2025 14:35
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants