Skip to content

SNOW-1660591 Remove sensitive encryption info when logging#2077

Merged
sfc-gh-pmotacki merged 11 commits intomasterfrom
SNOW-1660591-Remove-Encryption-Storage-Info-In-Logs
Mar 11, 2025
Merged

SNOW-1660591 Remove sensitive encryption info when logging#2077
sfc-gh-pmotacki merged 11 commits intomasterfrom
SNOW-1660591-Remove-Encryption-Storage-Info-In-Logs

Conversation

@sfc-gh-ext-simba-jf
Copy link
Copy Markdown
Collaborator

Overview

SNOW-1660591

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Parses out the "encryptionMaterial" from the JsonNode before logging

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner February 13, 2025 18:47
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf deleted the SNOW-1660591-Remove-Encryption-Storage-Info-In-Logs branch February 18, 2025 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf restored the SNOW-1660591-Remove-Encryption-Storage-Info-In-Logs branch February 20, 2025 23:52
Comment thread src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java Outdated
@sfc-gh-mhofman
Copy link
Copy Markdown
Contributor

@sfc-gh-mzurek can you have a look?

Comment thread src/main/java/net/snowflake/client/util/SecretDetector.java
Comment thread src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java Outdated
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit ef81582 into master Mar 11, 2025
137 of 140 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1660591-Remove-Encryption-Storage-Info-In-Logs branch March 11, 2025 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants