Snow 1915375 drop copyright header in comments from snowflake repositories#2091
Merged
sfc-gh-ext-simba-vb merged 15 commits intomasterfrom Mar 11, 2025
Conversation
…into SNOW-1016470-increase-code-coverage-to-at-least-90
…into SNOW-1915375-Drop-copyright-header-in-comments-from-Snowflake-repositories
Contributor
sfc-gh-astachowski
left a comment
There was a problem hiding this comment.
4 files still contain @author jrosen
Collaborator
Author
|
Hi @sfc-gh-astachowski ,Kindly review the changes. |
sfc-gh-astachowski
approved these changes
Mar 3, 2025
sfc-gh-astachowski
suggested changes
Mar 3, 2025
Contributor
sfc-gh-astachowski
left a comment
There was a problem hiding this comment.
I found a bunch more files with with the copyright in them (probably merged from main after you removed most of them), please remove them.
Collaborator
Author
|
sfc-gh-astachowski I modified newly added files. kindly review. |
sfc-gh-astachowski
approved these changes
Mar 4, 2025
…ents-from-Snowflake-repositories
Collaborator
Author
|
@sfc-gh-pszpakowski, Need one more approver for this PR. |
…ents-from-Snowflake-repositories
…ents-from-Snowflake-repositories
Collaborator
Author
|
@sfc-gh-pszpakowski, Could you please help assign 2nd reviewer to review this PR? |
sfc-gh-mkubik
approved these changes
Mar 11, 2025
…ents-from-Snowflake-repositories
…ents-from-Snowflake-repositories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1915375
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.