Skip to content

Snow 1915375 drop copyright header in comments from snowflake repositories#2091

Merged
sfc-gh-ext-simba-vb merged 15 commits intomasterfrom
SNOW-1915375-Drop-copyright-header-in-comments-from-Snowflake-repositories
Mar 11, 2025
Merged

Snow 1915375 drop copyright header in comments from snowflake repositories#2091
sfc-gh-ext-simba-vb merged 15 commits intomasterfrom
SNOW-1915375-Drop-copyright-header-in-comments-from-Snowflake-repositories

Conversation

@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator

Overview

SNOW-1915375

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb marked this pull request as ready for review February 22, 2025 02:09
@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb requested a review from a team as a code owner February 22, 2025 02:09
Copy link
Copy Markdown
Contributor

@sfc-gh-astachowski sfc-gh-astachowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files still contain @author jrosen

Comment thread src/main/java/net/snowflake/client/core/SFStatementType.java
Comment thread src/main/java/net/snowflake/client/jdbc/FileBackedOutputStream.java
Comment thread src/main/java/net/snowflake/client/jdbc/SnowflakeChunkDownloader.java Outdated
Comment thread src/main/java/net/snowflake/client/core/AssertUtil.java
@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator Author

Hi @sfc-gh-astachowski ,Kindly review the changes.

Copy link
Copy Markdown
Contributor

@sfc-gh-astachowski sfc-gh-astachowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bunch more files with with the copyright in them (probably merged from main after you removed most of them), please remove them.

@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator Author

sfc-gh-astachowski I modified newly added files. kindly review.

@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator Author

@sfc-gh-pszpakowski, Need one more approver for this PR.

@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator Author

@sfc-gh-pszpakowski, Could you please help assign 2nd reviewer to review this PR?

@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb merged commit 8f3def1 into master Mar 11, 2025
137 of 142 checks passed
@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb deleted the SNOW-1915375-Drop-copyright-header-in-comments-from-Snowflake-repositories branch March 11, 2025 19:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants