Skip to content

SNOW-1958601: Fix NPE when cache folder is inaccessible#2108

Merged
sfc-gh-pmotacki merged 5 commits intomasterfrom
SNOW-1958601-cache-file-check
Mar 14, 2025
Merged

SNOW-1958601: Fix NPE when cache folder is inaccessible#2108
sfc-gh-pmotacki merged 5 commits intomasterfrom
SNOW-1958601-cache-file-check

Conversation

@sfc-gh-pbulawa
Copy link
Copy Markdown
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Mar 4, 2025

Overview

SNOW-1958601

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • [] New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner March 4, 2025 13:35
@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-1958601-cache-file-check SNOW-1958601: Fix NPE when cache folder is inaccessible Mar 4, 2025
@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-1958601-cache-file-check branch from 8b8fdcc to 5d734f7 Compare March 4, 2025 13:38
Comment thread src/main/java/net/snowflake/client/core/FileCacheManager.java Outdated
Copy link
Copy Markdown
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please think about places I mentioned in previous comment?

Comment thread src/main/java/net/snowflake/client/core/FileUtil.java Outdated
Comment thread src/test/java/net/snowflake/client/core/FileCacheManagerTest.java
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1958601-cache-file-check branch from 265995e to e8f6ed6 Compare March 14, 2025 08:31
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 464540d into master Mar 14, 2025
138 of 142 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1958601-cache-file-check branch March 14, 2025 09:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants