Skip to content

SNOW-1965573 Fix file cache creation on windows#2115

Merged
sfc-gh-pfus merged 1 commit intomasterfrom
SNOW-1965573-cache-dir-creation-on-windows
Mar 11, 2025
Merged

SNOW-1965573 Fix file cache creation on windows#2115
sfc-gh-pfus merged 1 commit intomasterfrom
SNOW-1965573-cache-dir-creation-on-windows

Conversation

@sfc-gh-pfus
Copy link
Copy Markdown
Collaborator

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1965573-cache-dir-creation-on-windows branch from 86c534f to 15dcfd1 Compare March 10, 2025 09:55
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review March 10, 2025 09:56
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner March 10, 2025 09:56
Comment thread src/main/java/net/snowflake/client/core/FileCacheManager.java
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1965573-cache-dir-creation-on-windows branch from 15dcfd1 to 9fa36ce Compare March 10, 2025 11:18
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1965573-cache-dir-creation-on-windows branch from 9fa36ce to 3fcd89b Compare March 10, 2025 13:27
@sfc-gh-pfus sfc-gh-pfus merged commit f8ab78a into master Mar 11, 2025
139 of 142 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1965573-cache-dir-creation-on-windows branch March 11, 2025 06:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants