Skip to content

Remove dependency on com.amazonaws.util.StringUtils from SessionUtil #2125

Closed
jtjeferreira wants to merge 2 commits intosnowflakedb:masterfrom
jtjeferreira:prefer-guava-strings
Closed

Remove dependency on com.amazonaws.util.StringUtils from SessionUtil #2125
jtjeferreira wants to merge 2 commits intosnowflakedb:masterfrom
jtjeferreira:prefer-guava-strings

Conversation

@jtjeferreira
Copy link
Copy Markdown
Contributor

Overview

Similar to #1627, but for a dependency introduced in #1978.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: SNOW-1042432: Do not use com.amazonaws classes in core SF classes #1626

or should I create a new ticket?

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  2. Please describe how your code solves the related issue.

    Use com.google.common.base.Strings#isNullOrEmpty instead of com.amazonaws.util.StringUtils#isNullOrEmpty

@jtjeferreira jtjeferreira requested a review from a team as a code owner March 17, 2025 17:28
@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown
Contributor

sfc-gh-snowflakedb-snyk-sa commented Apr 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@jtjeferreira
Copy link
Copy Markdown
Contributor Author

Hi @sfc-gh-dprzybysz any update here?

@sfc-gh-wfateem
Copy link
Copy Markdown
Collaborator

sfc-gh-wfateem commented Apr 3, 2025

@jtjeferreira I was already working on another PR that already covers this class. There are a lot of other places where we depend on this method, but also, it's unnecessary to replace that with Guava just for that single isNullOrEmpty method. You can take a look at PR #2143

@sfc-gh-wfateem
Copy link
Copy Markdown
Collaborator

Closing this PR. Refer to #2143

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants