Remove dependency on com.amazonaws.util.StringUtils from SessionUtil #2125
Closed
jtjeferreira wants to merge 2 commits intosnowflakedb:masterfrom
Closed
Remove dependency on com.amazonaws.util.StringUtils from SessionUtil #2125jtjeferreira wants to merge 2 commits intosnowflakedb:masterfrom
jtjeferreira wants to merge 2 commits intosnowflakedb:masterfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
Author
|
Hi @sfc-gh-dprzybysz any update here? |
Collaborator
|
@jtjeferreira I was already working on another PR that already covers this class. There are a lot of other places where we depend on this method, but also, it's unnecessary to replace that with Guava just for that single |
Collaborator
|
Closing this PR. Refer to #2143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Similar to #1627, but for a dependency introduced in #1978.
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: SNOW-1042432: Do not use com.amazonaws classes in core SF classes #1626
or should I create a new ticket?
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Use
com.google.common.base.Strings#isNullOrEmptyinstead ofcom.amazonaws.util.StringUtils#isNullOrEmpty