Skip to content

Snow-1936378 add support for vector type for loader#2161

Merged
sfc-gh-pfus merged 45 commits intomasterfrom
SNOW-1936378-Add-support-for-vector-type-for-loader
Oct 23, 2025
Merged

Snow-1936378 add support for vector type for loader#2161
sfc-gh-pfus merged 45 commits intomasterfrom
SNOW-1936378-Add-support-for-vector-type-for-loader

Conversation

@sfc-gh-ext-simba-jf
Copy link
Copy Markdown
Collaborator

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown
Contributor

sfc-gh-snowflakedb-snyk-sa commented Apr 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf marked this pull request as ready for review April 28, 2025 05:38
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner April 28, 2025 05:38
Copy link
Copy Markdown
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test that checks the INT Vector?

Copy link
Copy Markdown
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 1394b84 into master Oct 23, 2025
146 of 163 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1936378-Add-support-for-vector-type-for-loader branch October 23, 2025 06:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants