Skip to content

SNOW-2107220: Add null check for write cache file#2188

Merged
sfc-gh-pbulawa merged 6 commits intomasterfrom
SNOW-2107220-fix-file-null-check
May 21, 2025
Merged

SNOW-2107220: Add null check for write cache file#2188
sfc-gh-pbulawa merged 6 commits intomasterfrom
SNOW-2107220-fix-file-null-check

Conversation

@sfc-gh-pbulawa
Copy link
Copy Markdown
Collaborator

Overview

SNOW-2107220

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: SNOW-2107220

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Do not attempt to write to the cache file if it does not exist.

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner May 20, 2025 12:51
@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown
Contributor

sfc-gh-snowflakedb-snyk-sa commented May 20, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit df57fde into master May 21, 2025
354 of 410 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-2107220-fix-file-null-check branch May 21, 2025 12:26
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants