SNOW-2161718-JDBC-fix-permission-check-for-toml-config#2270
Merged
sfc-gh-ext-simba-vb merged 45 commits intomasterfrom Sep 26, 2025
Merged
Conversation
sfc-gh-pbulawa
requested changes
Jul 29, 2025
Collaborator
sfc-gh-pbulawa
left a comment
There was a problem hiding this comment.
Remove the Windows file check.
sfc-gh-pbulawa
approved these changes
Aug 4, 2025
sfc-gh-pfus
reviewed
Aug 26, 2025
src/main/java/net/snowflake/client/config/SFConnectionConfigParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/config/SFConnectionConfigParser.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFConnectionConfigParserPermissionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFConnectionConfigParserPermissionTest.java
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFConnectionConfigParserPermissionTest.java
Outdated
Show resolved
Hide resolved
… of https://github.com/snowflakedb/snowflake-jdbc into SNOW-2161718-JDBC-fix-permission-check-for-toml-config
Collaborator
Author
|
Hi @sfc-gh-pfus, could you review this PR? |
…into SNOW-2161718-JDBC-fix-permission-check-for-toml-config
… of https://github.com/snowflakedb/snowflake-jdbc into SNOW-2161718-JDBC-fix-permission-check-for-toml-config
sfc-gh-dheyman
approved these changes
Sep 5, 2025
Collaborator
|
@sfc-gh-ext-simba-vb please update DESCRIPTION.md, because the changelog check fails |
Collaborator
Author
|
Hi @sfc-gh-dheyman, DESCRIPTION.md updated. Thanks |
…into SNOW-2161718-JDBC-fix-permission-check-for-toml-config
…into SNOW-2161718-JDBC-fix-permission-check-for-toml-config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-2161718
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.