Skip to content

Snow 2234383 test coverage for multistatement jdbc#2318

Merged
sfc-gh-ext-simba-vb merged 19 commits intomasterfrom
SNOW-2234383_Test_Coverage_For_Multistatement_JDBC
Sep 25, 2025
Merged

Snow 2234383 test coverage for multistatement jdbc#2318
sfc-gh-ext-simba-vb merged 19 commits intomasterfrom
SNOW-2234383_Test_Coverage_For_Multistatement_JDBC

Conversation

@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator

@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb commented Aug 25, 2025

Overview

SNOW-2234383

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb marked this pull request as ready for review August 26, 2025 05:14
@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb requested a review from a team as a code owner August 26, 2025 05:14
@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator Author

Hi @sfc-gh-pfus could you please review this PR?

@sfc-gh-ext-simba-vb
Copy link
Copy Markdown
Collaborator Author

Hi @sfc-gh-pfus, I have incorporated the comments. Could you review the PR?

@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb merged commit a84df02 into master Sep 25, 2025
274 of 279 checks passed
@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb deleted the SNOW-2234383_Test_Coverage_For_Multistatement_JDBC branch September 25, 2025 23:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants