Make play_time_secs reference configurable#91
Merged
Agnes Kiss (agnes-kiss) merged 1 commit intorelease/snowplow-media-player/0.9.4from Oct 9, 2025
Merged
Conversation
Snowplow CLA bot (snowplowcla)
added
the
cla:yes
Agnes Kiss (agnes-kiss)
requested review from
Asad Manzoor (asadmg) and
Matus Tomlein (matus-tomlein)
Matus Tomlein (matus-tomlein)
approved these changes
Oct 8, 2025
Contributor
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
There was a problem hiding this comment.
LGTM
Agnes Kiss (agnes-kiss)
merged commit 9d72ae9
into
release/snowplow-media-player/0.9.4
6 checks passed
Agnes Kiss (agnes-kiss)
deleted the
feature/make_playtimesec_configurable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
There has been a request from users to be able to decide how to calculate the
play_time_secswithin thebase_this_runtable to handle edge cases in tracking. This is enabled via a new dispatch macro calledplay_time_secs_base_this_run()where users will be free to override the reference.