Release/3.22.0 #1293
Merged
Release/3.22.0 #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igneel64
commented
Mar 7, 2024
•
igneel64
commented
- BrowserTracker: fix method type definitions #1284
- Export snowplow-ecommerce types for wrapper creation #1291
* BrowserTracker: fix method type definitions Per the [TypeScript docs](https://www.typescriptlang.org/docs/handbook/2/functions.html#return-type-void), functions that return values are type-compatible with functions declared as having void return type; however if you're consuming these type definitions this becomes annoying as you are required to cast `as unknown as T` at the call sites to get the correct types actually returned from these methods.
BundleMonFiles added (6)
Total files change +99.17KB 0% Final result: ✅ View report in BundleMon website ➡️ |
matus-tomlein
approved these changes
Mar 7, 2024
| "changes": [ | ||
| { | ||
| "packageName": "@snowplow/browser-tracker-core", | ||
| "comment": "", |
There was a problem hiding this comment.
Is it a problem that there is no comment in these changes?
There was a problem hiding this comment.
This will be used in the generated changelog (which I think we don't use anyway)
I don't think the empty entry will make a difference (think :P )
I don't know how it came up as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.