Skip to content

Conversation

@marcin-j
Copy link
Contributor

No description provided.

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@snowplowcla snowplowcla added the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label Jun 13, 2024
@marcin-j
Copy link
Contributor Author

I signed it!

@snowplowcla
Copy link

Confirmed! @marcin-j has signed the Contributor License Agreement. Thanks so much.

@snowplowcla snowplowcla added cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. and removed cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. labels Jun 13, 2024
@matus-tomlein matus-tomlein changed the base branch from master to release/3.24.0 June 18, 2024 05:22
@matus-tomlein matus-tomlein changed the title Fix custom document title override (close #1317) Fix custom document title override using setDocumentTitle (close #1317) Jun 18, 2024
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for identifying and fixing the bug @marcin-j!

This looks good, but can I please ask you for a small favour – please add the file below at the path common/changes/@snowplow/browser-tracker-core/marcin-j-master_2024-06-18-05-25.json and commit in this branch.

marcin-j-master_2024-06-18-05-25.json

@marcin-j
Copy link
Contributor Author

HI @matus-tomlein, I've added the file

@bundlemon
Copy link

bundlemon bot commented Jun 18, 2024

BundleMon

Files added (6)
Status Path Size Limits
libraries/browser-tracker-core/dist/index.mod
ule.js
+27.3KB 28KB / +10%
trackers/javascript-tracker/dist/sp.js
+25.37KB 25.5KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+15.68KB 16KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+15.55KB 16KB / +10%
libraries/tracker-core/dist/index.module.js
+13.36KB 15KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.51KB 5KB / +10%

Total files change +100.77KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@matus-tomlein matus-tomlein merged commit e01cb31 into snowplow:release/3.24.0 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants