Add a configurable default label in button click tracking and fix disabling for specific trackers (close #1397 and #1421) #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes snowplow#1397. Also fixes a test that wasn't actually running.
| @@ -18,6 +18,8 @@ export interface ButtonClickTrackingConfiguration { | |||
| filter?: Filter; | |||
| /** The dynamic context which will be evaluated for each button click event */ | |||
| context?: DynamicContext; | |||
| /** A default label to use if one can not be determined by the content or data attributes */ | |||
There was a problem hiding this comment.
If I understand correctly, if this is not specified, the default will be (empty), should we note this here or somewhere else?
There was a problem hiding this comment.
Maybe this will be more visible in the tracker docs.
matus-tomlein
changed the title
matus-tomlein
changed the title
matus-tomlein
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label((empty)) for button_click events where one can not be determined by the button's content or data attributes (see Add empty string tobutton_clickevent #1421)Technically a breaking change, but only in the sense that events that were previously bad will not be any more. A fixing change? So aiming for 4.5.0 since a minor release seems appropriate.