Fix Element Tracking element_content entity properties #1430
+19
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for publishing the Element Tracking schemas to Iglu Central, changes were made to the
element_content
schema to be more consistent with the other related schemas.The type definition in the plugin implementation was updated to match, but the function that builds the context with that entity also includes the entities from the user's custom entity generators, so accepts arbitrary
SelfDescribingJson
to build a context of type(ElementContentEntity | SelfDescribingJson)[]
. Since the implementation for that entity was not updated, it no longer satisfiedElementContentEntity
but did still satisfySelfDescribingJson
, so passed the type check and compiled successfully, despite no longer matching the schema.This builds the entity in a type-safer way, declaring it explicitly as
ElementContentEntity
, and fixes the implementation to match the schema.