feat: retrieve real findings [IDE-245] #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/findings-url
branch
2 times, most recently
from
385c1b8 to
c115a3f
Compare
teodora-sandu
changed the title
teodora-sandu
force-pushed
the
feat/findings-url
branch
from
c115a3f to
1810368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the call to retrieve the findings from the findings URL. Also added a simple Pact contract test for the Analysis APIs and improved the unit tests a bit so that the mocks verify the URL being called, which helps differentiate between mocks and makes sure we don't use the response from a different mock.
Tested using smoke tests.