-
Notifications
You must be signed in to change notification settings - Fork 14
feat: add extensible auth field monitor for automatic logout #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implements extensible infrastructure to automatically trigger logout when authentication-sensitive fields (endpoint, authenticationMethod) change. Key changes: - Add change listener system to dirty tracker for extensibility - Create auth-field-monitor module that monitors auth-sensitive fields - Register monitor as listener to detect changes in real-time - Remove previous endpoint tracking from auto-save (now handled by monitor) - Remove duplicate token validation on auth method change The new architecture allows any module to register change listeners with the dirty tracker, making it easy to extend with additional monitors in the future without coupling business logic to the tracker itself.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @nick-y-snyk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust and extensible mechanism to enhance security by automatically logging out users when critical authentication-related configuration fields are modified. By integrating with the existing dirty tracker, the system now provides a centralized way to monitor data changes and react to them, ensuring that any alterations to sensitive authentication settings prompt a necessary re-authentication. This design improves maintainability and allows for easy addition of new fields to monitor in the future. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a well-designed, extensible mechanism for automatically logging out the user when authentication-sensitive fields are changed. The new change listener pattern in the dirtyTracker is a solid foundation for this and other features. The code is clean, and the refactoring to remove the old endpoint tracking logic is a good improvement. My main review point concerns the authFieldMonitor module, which doesn't fully implement the extensibility described in the pull request summary. I've provided a detailed comment with a code suggestion to align the implementation with the stated design goals.
Summary
Implements extensible infrastructure to automatically trigger logout when authentication-sensitive fields change, using the dirty tracker's change listener pattern.
Changes
addChangeListener,_notifyChangeListeners)endpointandauthenticationMethodfieldsArchitecture
The dirty tracker now fires callbacks to registered listeners on every data change, passing both original and current data. This allows monitors to implement custom logic without coupling to the tracker.
Extensibility
New monitors can be added by:
Or extend existing monitors:
Test plan