feat: add remy-backed RemediationProvider skeleton [IDE-2052]

[bastiandoetsch]

User description

Summary

• Add remyProvider struct backed by gafRunner (invokes GAF "fix" workflow)
• NewRemyProvider(engine, runner) — runner is the test seam
• FileChangeNotifier interface with InvalidateFile(path)
• Wire InvalidateFile into textDocument/didChange and textDocument/didSave LSP handlers via deps.RemediationNotifier
• Gate remyProvider construction behind remediation_agent_enabled config key

PR Stack — Merge Order

flowchart LR
    main(["main"])
    PR1["#1326 PR-1\nfindingId + kind"]
    PR2["#1327 PR-2\nCA provider"]
    PR3["#? PR-3 ← YOU ARE HERE\nremy initial"]
    PR4["#? PR-4\nworktree impl"]
    PR5["#? PR-5\nunit tests"]
    PR6["#? PR-6\ninteg+smoke tests"]
    main --> PR1 --> PR2 --> PR3 --> PR4 --> PR5 --> PR6
    style PR3 fill:#ffd700,color:#000

Loading

Depends on: #1327

Test plan

• make test passes

---

PR Type

Enhancement

---

Description

• Introduce Remy-backed RemediationProvider.

• Integrate provider into CodeActionService.

• Enable via configuration flag remediation_agent_enabled.

• Convert git diffs to WorkspaceEdits.

---

Diagram Walkthrough

flowchart LR
  A[Configuration: remediation_agent_enabled] --> B(RemyProvider);
  B --> C(CodeActionService);
  B -- Uses --> D{Remy CLI};
  D -- Mutates --> E[Git Worktree];
  E -- Generates --> F(Git Diff);
  F --> B;

Loading

File Walkthrough

Relevant files

Enhancement

init.go Integrate Remy RemediationProvider into DI.                            application/di/init.go Imports the remediation package. Initializes RemyProvider conditionally based on the remediation_agent_enabled configuration. Injects the RemediationProvider into the CodeActionService. Defines the remediationAgentEnabledKey constant. +18/-1    provider.go Define RemediationProvider interface.                                        domain/snyk/remediation/provider.go Defines the RemediationProvider interface for autonomous fixing. Adds an "Isolation contract" comment clarifying implementation responsibilities regarding worktree mutation. +4/-0      remy.go Implement Remy RemediationProvider logic.                                domain/snyk/snyk/remediation/remy.go Implements the RemediationProvider interface using the snyk remy CLI. Handles worktree mutation via a remyRunner (defaulting to subprocess execution). Generates types.WorkspaceEdit by parsing git diffs between pre- and post-mutation states. Includes helper functions for git operations, diff parsing, and subprocess execution.

---

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[bastiandoetsch]

/describe

[snyk-pr-review-bot]

PR Reviewer Guide 🔍

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Destructive Workspace Mutation 🔴 [critical] The initApplication function wires the RemyProvider using the live workspace folder path (w / folderPath). However, the RemediationProvider isolation contract (defined in provider.go) states that implementations may mutate the root in place and requires an isolated copy (e.g., a git worktree). By passing the live folder, snyk remy will modify the user's source code on disk immediately when the code action is resolved (typically upon clicking the lightbulb), before the user has reviewed or accepted the WorkspaceEdit. This results in a 'double-apply' where the IDE tries to apply a diff to a file that has already changed on disk, potentially causing conflicts or corrupting the buffer. remediationProvider = remediation.NewRemyProvider(remediation.RemyOptions{ CliPath: config.GetCliPath(conf), Logger: &lp, }, nil) } codeActionService = codeaction.NewService(engine, w, fileWatcher, notifier, featureFlagService, configResolver, remediationProvider) Data Loss Risk 🔴 [critical] The Remediate function uses git diff HEAD (via gitChangedFiles and gitFileDiff) to calculate the changes to package into a WorkspaceEdit. Because the provider is currently wired to the live workspace rather than an isolated worktree, this diff will include all of the user's uncommitted changes in the final WorkspaceEdit. When the IDE applies this edit, it may overwrite the user's intentional, uncommitted modifications with a state derived from HEAD plus the AI's changes, leading to silent data loss of the user's local work. cmd := exec.CommandContext(ctx, "git", "-C", root, "diff", "--name-only", "HEAD") out, err := cmd.Output() if err != nil { return nil, fmt.Errorf("git diff --name-only: %w", err) } var paths []string for _, p := range strings.Split(strings.TrimSpace(string(out)), "\n") { if p != "" { paths = append(paths, p) } } return paths, nil } // gitFileDiff returns the unified diff for relPath from HEAD to the working // tree in the repository at root. Returns an empty string if the file is // unchanged. func gitFileDiff(ctx context.Context, root, relPath string) (string, error) { cmd := exec.CommandContext(ctx, "git", "-C", root, "diff", "HEAD", "--", relPath) Logic Error in Diff Parser 🟠 [major] In parseDiffHunks, the handling of the \ No newline at end of file marker is incorrect. It decrements s.currentLine without removing the newline character (\n) that was automatically appended to the preceding insertion in applyInsertion. This will cause the remediation agent to incorrectly add a trailing newline to files that do not have one. Furthermore, if the marker appears at the start of a file or hunk, currentLine can become negative, causing makeLineEdit to return an error and fail the entire remediation for that file. if line == `\ No newline at end of file` { // Compensate for the line counter being one ahead of reality. s.currentLine-- continue } Missing Auth Context 🟠 [major] makeSubprocessRunner inherits the parent process environment via os.Environ(). In most language server deployments, the authentication token is provided via LSP configuration and stored in the LS memory/engine, not in the process's OS environment variables. Without threading the configResolver to inject the SNYK_TOKEN, the subprocess call to snyk remy will likely fail due to lack of authentication. cmd.Env = os.Environ()

📚 Repository Context Analyzed This review considered 18 relevant code sections from 14 files (average relevance: 0.92) infrastructure/code/code.go (lines 1-163) domain/ide/workspace/folder.go (lines 1-225) domain/ide/command/code_fix.go (lines 1-148) domain/ide/command/code_fix_diffs.go (lines 1-99) domain/snyk/remediation/noop.go (lines 1-33) infrastructure/code/types.go (lines 1-117) application/di/test_init.go (lines 1-161) ... and 7 more file(s)

[snyk-pr-review-bot]

PR Description updated to latest commit (9bac438)

[bastiandoetsch]

/describe

[snyk-pr-review-bot]

PR Description updated to latest commit (9bac438)

[bastiandoetsch]

/describe

[snyk-pr-review-bot]

PR Description updated to latest commit (2d61f9d)

[bastiandoetsch]

Addressing bot findings:

Destructive Workspace Mutation + Data Loss Risk: Both criticals are valid for this PR viewed in isolation. The worktree isolation that prevents live workspace mutation is introduced in the next PR in this stack (#1329 feat/IDE-2052-pr4), which clones ContentRoot into a detached git worktree before invoking remy. The RemediationProvider interface contract (provider.go:39-41) documents this as a caller responsibility — PR #1329 fulfils it. Not fixed in this PR; fixed in the stacked parent.

[basti-snyk]

/describe

[snyk-pr-review-bot]

PR Description updated to latest commit (37e017b)