Chore/wayne test pl#1358
Draft
wayne-grant wants to merge 2 commits into
Draft
Conversation
…IDE-2108] Test_SmokeScanPrecedence_OSSEnabled_CodeDisabled flaked on Ubuntu CI: the OSS scan never completed (ran to a 28s timeout), with config-file errors from a parallel test in the logs. Root cause: the smoke-test setup helpers mutated the process-global xdg.ConfigHome (read by storage.NewStorageWithCallbacks via xdg.ConfigFile) and restored it in t.Cleanup. When two smoke tests ran concurrently, each writing its own t.TempDir() to that global, one test's storage/folder-config resolved into another test's directory — the folder config file was missing and the scan stalled. Fix: drop the xdg.ConfigHome mutation and instead set an explicit per-test SettingConfigFile on the engine configuration. folderconfig.ConfigFileFromConfig returns that explicit path before ever consulting the xdg global, so each test is fully isolated without touching shared process state. Applied at all four setup sites (precedence_smoke_test.go x3, ldx_sync_smoke_test.go). Adds isolation-invariant regression tests proving ConfigFileFromConfig returns the explicit path for the primary, legacy, and user-global keys and never falls back to xdg.ConfigHome. Produced by an automated flake-fix loop.
|
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
2534aed to
4d6281e
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
4d6281e to
e9053c4
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
e9053c4 to
a692449
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
4 times, most recently
from
9d68393 to
cb20d8d
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
cb20d8d to
4d561b3
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
4d561b3 to
e11406b
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
e11406b to
dad69e7
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
dad69e7 to
4f057f2
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
4f057f2 to
0e243f0
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
0e243f0 to
9e7bb35
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
9e7bb35 to
3aecc3a
Compare
wayne-grant
force-pushed
the
chore/wayne-test-pl
branch
from
3aecc3a to
b401caf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
make generate)make lint-fix)