fix: WIP ignore Issue View Options when CCI disabled [IDE-899] #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the IDE's IVOs would still be applied even if Code Consistent Ignores was not enabled in the org. Now all issues will be returned if CCI is not enabled regardless of the IDE's settings.
Switch fully to using GAF for fetching feature flag statuses. Plus update tests for using GAF's API.
rrama
commented
Apr 4, 2025
| ff := snyk_api.FeatureFlagType(ffStr) | ||
| ffResponse, err := cmd.apiClient.FeatureFlagStatus(ff) | ||
| // No need for language server to enforce which feature flags exist or not. | ||
| enabled := config.CurrentConfig().Engine().GetConfiguration().GetBool(ffStr) |
There was a problem hiding this comment.
Doesn't work as it isn't the GAF internal name for the feature flag...
|
Splitting this PR into two PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before the IDE's IVOs would still be applied even if Code Consistent Ignores was not enabled in the org.
Now all issues will be returned if CCI is not enabled regardless of the IDE's settings.
Also this now uses the new GAF API for fetching feature flags.
We can figure out the configuration caching another day, for now it calls the API 5 times during the scan to fetch the feature flag.
Checklist