feat: ignore request command [IDE-1063] #825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
force-pushed
the
feat/IDE-1063_ignore-request-command
branch
from
21bb73f to
5a9bcd8
Compare
acke
force-pushed
the
feat/IDE-1063_ignore-request-command
branch
from
5a9bcd8 to
f3c0dcc
Compare
acke
force-pushed
the
feat/IDE-1063_ignore-request-command
branch
from
f3c0dcc to
2f3da48
Compare
acke
force-pushed
the
feat/IDE-1063_ignore-request-command
branch
from
2f3da48 to
39eef13
Compare
| } | ||
|
|
||
| func (cmd *submitIgnoreRequest) sendShowDocumentRequest(issue types.Issue) { | ||
| snykUri, _ := code.SnykMagnetUri(issue, code.ShowInDetailPanelIdeCommand) |
There was a problem hiding this comment.
please refactor, this seems like code duplication with autofix. also, errors must be handled.
Comment on lines
186
to
201
| ignoreType, ok := cmd.command.Arguments[2].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("ignoreType should be a string") | ||
| } | ||
| reason, ok := cmd.command.Arguments[3].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("reason should be a string") | ||
| } | ||
| expiration, ok := cmd.command.Arguments[4].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("expiration should be a string") | ||
| } | ||
| ignoreId, ok := cmd.command.Arguments[5].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("ignoreId should be a string") | ||
| } |
There was a problem hiding this comment.
some of the argument checks are also duplications, please refactor accordingly to only have the necessary code once.
domain/snyk/issues.go
Outdated
| Fingerprint string | ||
| GlobalIdentity string | ||
| SuppressionStatus string | ||
| FindingsId string |
There was a problem hiding this comment.
should be findingId
There was a problem hiding this comment.
do we need json tags? please add if needed
internal/types/command.go
Outdated
Comment on lines
31
to
44
| GetActiveUserCommand = "snyk.getActiveUser" | ||
| TrustWorkspaceFoldersCommand = "snyk.trustWorkspaceFolders" | ||
| OpenLearnLesson = "snyk.openLearnLesson" | ||
| GetLearnLesson = "snyk.getLearnLesson" | ||
| GetSettingsSastEnabled = "snyk.getSettingsSastEnabled" | ||
| GetFeatureFlagStatus = "snyk.getFeatureFlagStatus" | ||
| GetActiveUserCommand = "snyk.getActiveUser" | ||
| ReportAnalyticsCommand = "snyk.reportAnalytics" | ||
| WorkspaceScanCommand = "snyk.workspace.scan" | ||
| WorkspaceFolderScanCommand = "snyk.workspaceFolder.scan" | ||
| ClearCacheCommand = "snyk.clearCache" | ||
| ReportAnalyticsCommand = "snyk.reportAnalytics" | ||
| GenerateIssueDescriptionCommand = "snyk.generateIssueDescription" | ||
| OpenBrowserCommand = "snyk.openBrowser" | ||
| NavigateToRangeCommand = "snyk.navigateToRange" | ||
| OpenLearnLesson = "snyk.openLearnLesson" | ||
| GetLearnLesson = "snyk.getLearnLesson" | ||
| SubmitIgnoreRequest = "snyk.submitIgnoreRequest" |
| @@ -88,8 +88,10 @@ type Issue interface { | |||
| GetMessage() string | |||
| GetFormattedMessage() string | |||
| GetAffectedFilePath() FilePath | |||
| GetContentRoot() FilePath | |||
| GetIsNew() bool | |||
| GetIsIgnored() bool | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New LS command for policy CRUD operations
Operation (CREATE,UPDATE,DELETE)
ignoreId (might be empty in case of CREATE)
reason (wont-fix, not-vulnerable, temporary-ignore)
expirationDate
comment
The LS Command should trigger the GAF Ignore WF created in IDE-1058.
Enrich the cached LS Issue with the GAF Ignore WF workflow afterwards.
Send generateIssueDescription Notification to refresh the page
Checklist