Skip to content

fix: propagate Maven error detail instead of hardcoded message [CSENG… #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neema-beglou-snyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: propagate Maven error detail instead of hardcoded message [CSENG… #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/maven/dependency-tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,12 @@ export async function executeMavenDependencyTree(
if (error instanceof Error) {
const message = error.message;
if (message.includes('Non-parseable POM')) {
throw new OpenSourceEcosystems.UnableToParseXMLError(
'Error parsing the XML file',
);
throw new OpenSourceEcosystems.UnableToParseXMLError(message);
}
}

throw new OpenSourceEcosystems.FailedToBuildMavenProjectError(
'Cannot build Maven dependency tree',
);
const detail =
error instanceof Error ? error.message : 'Cannot build Maven dependency tree';
throw new OpenSourceEcosystems.FailedToBuildMavenProjectError(detail);
}
}