-
Notifications
You must be signed in to change notification settings - Fork 0
All commits #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: empty-branch
Are you sure you want to change the base?
All commits #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto! Interesting paper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting paper. Also interesting that "switching accounts for none of mainline decline" . Maybe add some information of the method/ model used in the summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Also, if you want to focus on the difference in fertility rates between the two groups, when not plot that directly for each year and then do a loess on that difference?
In general, it is always good to plot the quantity of interest and not ask the reader to do the transformation you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! A nice project and interesting extension finding. My main question is whether you can automate some of the recoding that you do - perhaps create functions for the different recodes that you can plug into dplyr. I think this might save work by cutting down on repetition and also minimize the chance of mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Leah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Your commenting is excellent throughout the project.
Merge pull request #1 from JBirdsall/master
Merge pull request #1 from gracetien/master
No description provided.