Escape special characters in option 6 PowerShell script #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some characters such as ), & had to be escaped but they weren't.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the Windows batch file where special characters were not properly escaped within a PowerShell script generation block. The batch file uses a parenthesized redirection block to create a temporary PowerShell script, and within such blocks, special characters like ) and & must be escaped with ^ to prevent premature block termination and incorrect command parsing.
Key Changes:
- Escaped all closing parentheses
)with^)throughout the PowerShell script generation block (lines 697-774) - Escaped the ampersand
&with^&when invoking the external command (line 701)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some characters such as ), & had to be escaped but they weren't.