split massflash and add state info [WIP] post scale 22 #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split massflash into two parts: 1. interface with kea 2. execute the upgrade the 2nd part can then be used by other scripts such as upgrade subset rolling upgrade
kylerisse
approved these changes
Mar 5, 2025
Member
kylerisse
left a comment
kylerisse
left a comment
There was a problem hiding this comment.
thanks @sarcasticadmin , glad to see it working and APs flashing success!
|
|
||
| scp -O -P $ssh_port \ | ||
| -i $state_dir/id_priv \ | ||
| -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no \ |
Member
There was a problem hiding this comment.
my only suggestion would be to make the ssh args a variable to DRY it over but not worth blocking merge on.
kylerisse
requested changes
Mar 5, 2025
Member
kylerisse
left a comment
kylerisse
left a comment
There was a problem hiding this comment.
let's wait on this @davidelang @sarcasticadmin
Member
|
this makes sense since calling this script outside of massflash would be useful, thanks @davidelang let us know how things go after you test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet tested, being posted for discussion on the approach.
split massflash into two parts:
the 2nd part can then be used by other scripts such as
upgrade subset
rolling upgrade