Add support for grouped rules #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke rules defined by fields of type ArchTests which include rules defined in other classes. See also https://www.archunit.org/userguide/html/000_Index.html#_grouping_rules Fixes societe-generale#70
mkjensen
commented
Mar 12, 2025
| @@ -105,11 +131,11 @@ InvocationResult invokeOn(JavaClasses importedClasses) { | |||
|
|
|||
| InvocationResult result = new InvocationResult(); | |||
| for (Method method : archRuleMethods) { | |||
| checkForFailure(() -> invoke(method, instance, importedClasses)) | |||
| checkForFailure(() -> invoke(method, null, importedClasses)) | |||
There was a problem hiding this comment.
ArchUnit examples use static fields and methods so no need for an instance here.
If it turns out an instance is needed, then more work is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Invoke rules defined by fields of type
ArchTestswhich include rules defined in other classes.See also https://www.archunit.org/userguide/html/000_Index.html#_grouping_rules
Fixes #70
Details
Extended InvokableRules to also support ArchTests.
Context
Checklist:
Related issue :
#70