Skip to content

Conversation

@Harsh5488
Copy link
Contributor

• Using ConcurrentHashMap for multi-threaded environment

• Making clearAcks() public for clearing acknowledgement when needed

• Making clearAcks() public for clearing acknowledgement when needed
@Harsh5488
Copy link
Contributor Author

Harsh5488 commented Jan 4, 2025

It can solve the issues related to the concurrency
@darrachequesne Please review and merge the changes

@seven4pl
Copy link

@Harsh5488 good job! I had a similar problem with clearing the queue.

@darrachequesne +1 for public clearAcks

@Harsh5488
Copy link
Contributor Author

@darrachequesne
Could you please provide more information on
Why to make the clearAcks() function to be private and called on onclose(String reason) function?

@Harsh5488 Harsh5488 closed this by deleting the head repository Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants