refactor connection to use MessagePack instead of JSON#10
Open
ggmichaelgo wants to merge 7 commits intosocketry:mainfrom
Open
refactor connection to use MessagePack instead of JSON#10ggmichaelgo wants to merge 7 commits intosocketry:mainfrom
ggmichaelgo wants to merge 7 commits intosocketry:mainfrom
Conversation
Contributor
|
We don't need to add our own framing: require "msgpack"
require "socket"
require "async"
factory = MessagePack::Factory.new
sockets = Socket.pair(:UNIX, :STREAM)
packer = factory.packer(sockets[0])
unpacker = factory.unpacker(sockets[1])
Async do
Async do
while true
puts unpacker.read
end
end
Async do
while true
packer.write("Hello, World #{Time.now}!")
packer.flush
sleep rand
end
end
endMessagePack already knows how long each message is internally. (flush is not strictly needed, it's just to ensure the message is sent across the wire at that time - it does not impact framing). |
ed896b2 to
e9e3fb6
Compare
7eb82b5 to
5a49511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
PR Summary
Instead of using JSON string for communicating between supervisor and workers, use MessagePack instead for better performance and String safety.
Async::Container::Supervisor::MessageWrapperhas been newly introduced to this gem.The
MessageWrappernormalizes the message object by invoking the message object'sas_jsonfunction.Connectionuses the newMessageWrapperand for now I have configured it to have 4GiB. (maximum value from unsigned 32-bit int / may be unsigned 16-bit int with 65KB will be enough 🤔)Contribution