-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ruby 3.3 #79
Support Ruby 3.3 #79
Conversation
Thanks for this! @tarcieri if you don't want to maintain this gem, do you want to:
I can triage this issue and release. LMK what you prefer to do. |
Sure, that sounds good to me. Let's transfer it to socketry |
Okay, I'll await your transfer. |
It's transferred |
Thanks @tarcieri do you mind adding me as an owner on Rubygems.org too? Thanks! |
Invite sent |
@k0kubun I want to add CI before we merge this PR, please give me a couple of days to sort it out. |
Sure, that makes sense. Thank you for working on that. |
b3bc86f
to
17b12fa
Compare
@k0kubun I could not get this to pass CI, but master branch is passing. Do you mind taking a look if you have time? |
(it might just be flaky test suite... I tried several times, even master is a bit unreliable). |
This looks okay to me now. I think we should try to move |
Well, two out of the three |
Fixed the other one though 390ff4e. Only this one makes sense to me. |
Thanks for your effort. I'll try to cut a release soon. |
@k0kubun it sounds like you may have software using cool.io - can you test it with the latest release if so? |
My contribution socketry/cool.io#79 has been merged and released.
I upgraded cool.io to the released version on yjit-bench Shopify/yjit-bench@2858bc3. The extension compiles correctly on Ruby master. The |
Fix #77
This follows the example fix shown in [Feature #19057] at 94dbdd9497. I also changed
#if HAVE_RB_IO_T
to#if defined(HAVE_RB_IO_T)
so that it will not print warnings when not defined.