Skip to content

Commit 228da16

Browse files
committed
Add comment
1 parent 6bd90d4 commit 228da16

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

soda-core/src/soda_core/common/sql_dialect.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -624,6 +624,12 @@ def get_schema_prefix_index(self) -> int | None:
624624
return 1
625625

626626
def sql_expr_timestamp_with_tz_literal(self, datetime_in_iso8601: str) -> str:
627+
"""Convert to a SQL representation of a timestamp with timezone.
628+
629+
By default this will return the standard SQL timestamp representation but may be overridden.
630+
We may wish to add some logic to detect timezones in datetime and return the appropriate representation.
631+
For now it's up to the user to decide which representation to use.
632+
"""
627633
return self.sql_expr_timestamp_literal(datetime_in_iso8601)
628634

629635
def sql_expr_timestamp_literal(self, datetime_in_iso8601: str) -> str:

0 commit comments

Comments
 (0)